Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git commit hash to version in form X.Y.Z.dev-gitgitsha-indexclean #291

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

oplatek
Copy link
Contributor

@oplatek oplatek commented Apr 29, 2021

Hi there!

I added git SHA to the version in setup.py in the format X.Y.Z.dev-SHA-dirty or X.Y.Z.dev-SHA-clean
The clean option is added when the git index is clean (on all releases).

I find it particularly useful if Lhotse is installed via pip install git+https://github.com/lhotse-speech/lhotse

$ pip list | grep lhotse   # see the second column for the version example
lhotse                        0.6.0.dev-2840393-clean /home/oplatek/code/lhotse

@pzelasko
Copy link
Collaborator

Thanks, looks great!

@pzelasko pzelasko merged commit 4c4227c into lhotse-speech:master Apr 29, 2021
@pzelasko pzelasko added this to the v0.7 milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants