On-the-fly cut filtering + improvements in arrow/lazy-dict #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/lazy-manifests-impr2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds a
.filter()method for sampler which is useful when dealing with large and lazy manifests. I reached out to Arrow developers and learned that they already support automatic schema inference in Python, I just didn't discover it -- I'm removing some code related to that. I also optimized lazy reading a bit by making the chunks larger (makes for less frequent disk reads) and moved to random-access Arrow format (not leveraged yet but I have some ideas, we'll see).