fix: trim titles and skip empty entries #15
Conversation
src/things.ts
Outdated
| @@ -50,22 +50,27 @@ export function buildTasksFromSQLRecords( | |||
| const tasks: Record<string, ITask> = {}; | |||
| taskRecords.forEach(({ tag, ...task }) => { | |||
| const id = task.uuid; | |||
| if(!id) { return } // Sometimes a record with no data is present | |||
There was a problem hiding this comment.
I think it makes sense to filter out empty records inside getTasksFromThingsLogbook instead.
There was a problem hiding this comment.
I dug a bit more to figure why there were empty records. Turns out that the CSV dump from SQLite had an empty line at the ending of it. A null record would be present when Papa parsed the CSV.
To fix this I added the skipEmptyLines option in the Papa config. This means we don't have to have the defensive check here. I also modified the WHERE on the checklist query to exclude rows with an empty title.
Overall, I'm quite pleased with how this turned out now.
There was a problem hiding this comment.
Aha! Really great catch. The null record issue really had me for a loop and I never took the time to debug. Thanks for digging into this further 🙏
This cleans up the visual output (no trailing whitespaces). I noticed that a trailing `null` entry was coming out from the CSV parsing of the SQLite dump. This was because we didn't have the `skipEmptyLines` to avoid `null` records from showing up.
This cleans up the visual output (no trailing whitespaces).
I noticed that a trailing
nullentry was coming out from the CSVparsing of the SQLite dump. This was because we didn't have the
skipEmptyLinesto avoidnullrecords from showing up.