Fix: Add WebSocket existence check before checking readyState #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WlanKabL
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to ensure that the
this.websocketobject exists before attempting to access itsreadyState. This prevents runtime errors when trying to disconnect or interact with an undefined or null WebSocket instance.Why this change?
Without this change, attempting to access
this.websocket.readyStatewhenthis.websocketis null or undefined will cause a runtime error. This update ensures a safer check for the WebSocket state, preventing potential crashes.Testing:
Tested by simulating cases where
this.websocketmight not be defined. Verified that the program no longer crashes and behaves correctly when trying to disconnect or check WebSocket status.