Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Shut down with an error message when site_url is not provided #21

Closed
anatoly-scherbakov opened this issue Mar 20, 2022 · 3 comments
Closed

[FEATURE] Shut down with an error message when site_url is not provided #21

anatoly-scherbakov opened this issue Mar 20, 2022 · 3 comments
Assignees
@liang2kl
Labels
enhancement New feature or request

Comments

@anatoly-scherbakov
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In the docs, it is clearly stated that site_url configuration parameter must be present for the plugin to properly function. I was still a bit confused because I misread the docs and thought about site_name instead.

Describe the solution you'd like
I would suggest that the plugin shuts down and explicitly requests the user to provide site_url in the configuration file.
@liang2kl
Copy link
Owner

Yes, that is a problem.

@liang2kl liang2kl self-assigned this Mar 20, 2022
@liang2kl liang2kl added the enhancement New feature or request label Mar 20, 2022
@anatoly-scherbakov
Copy link
Contributor Author

@liang2kl I am preparing a PR for this, one moment.

anatoly-scherbakov added a commit to octadocs/mkdocs-blogging-plugin that referenced this issue Mar 20, 2022
@anatoly-scherbakov
liang2kl#21 [FEATURE] Shut down with an error message when site_url…
d934ba6 
… is not provided
liang2kl added a commit that referenced this issue Mar 20, 2022
@liang2kl
Merge pull request #22 from octadocs/issue-21-error-on-missing-site-url
53913ed 
#21 [FEATURE] Shut down with an error message when `site_url` is not provided
@liang2kl
Copy link
Owner

Merged. Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liang2kl liang2kl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anatoly-scherbakov @liang2kl