Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change (or disable) the default driver name for registration #1160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

demoManito
Copy link

Description

A link variable now allows to change or disable the name of the driver that is automatically registered with database/sql.
This allows users to give the postgres name to another database/sql driver.

The implementation is the same as in: https://github.com/go-sql-driver/mysql driver. See https://github.com/go-sql-driver/mysql/blob/af8d7931954ec21a96df9610a99c09c2887f2ee7/driver.go#L92

Usage

Change the driver name to custom:

go build "-ldflags=-X github.com/lib/pq.driverName=custom"

Disable the automatic driver registration (set driverName to an empty string):

go build "-ldflags=-X github.com/lib/pq.driverName="

In the same way, a variable overridable at link time is also provided to override the driver name used in the test suite. This allows to run our test suite on another driver.

go build "-ldflags=-X github.com/lib/pq.driverNameTest=custom"

driverName is propagated to driverNameTest unless driverNameTest is explicitely defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant