Avoid potential runtime panic in connection initialization #666
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to use `$HOME` to find the user's home directory to avoid calling `user.Current`, which can runtime panic due to a known glib bug. This emulates the fix in https://go-review.googlesource.com/c/oauth2/+/34175, to work around http://golang.org/issue/13470
7 tasks
maddyblue
approved these changes
Oct 18, 2017
pgaskin
approved these changes
Oct 18, 2017
|
This does solve go-gitea/gitea#2728 based on my testing. |
necaris
changed the title
user.Current which can runtime panicuser.Current in connection initialization, which can runtime panic
necaris
changed the title
user.Current in connection initialization, which can runtime panic
ainar-g
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to use
$HOMEto find the user's home directory to avoid callinguser.Current, which can runtime panic due to a known glibc bug. This emulates the fix in https://go-review.googlesource.com/c/oauth2/+/34175, to work around http://golang.org/issue/13470 .