Support for SCRAM-SHA-256 authentication #788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis failure (https://travis-ci.org/lib/pq/jobs/426071817) does not appear to be related to the changes. |
|
+1 a.k.a. would be nice to have this feature |
|
Missing SCRAM support really starts to become a problem. This or #608 |
This was referenced Apr 9, 2019
|
maybe the tests could be used with the merged scram auth? |
|
This PR has been superseded by #833 and can be closed. |
|
@knz: Can you close this PR? |
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add support for SCRAM authentication.
The code in scram.go is an implementation of RFC 5802 and similar to the canonical C implementation at https://github.com/postgres/postgres/blob/master/src/interfaces/libpq/fe-auth-scram.c.
Testing
The test code in scram_test.go tests users with md5 and scram verifiers against md5 and scram matches in pg_hba.conf. To test locally, first update your local pg_hba.conf with the changes in .travis.sh.
Dependencies
The code introduces two new dependencies,
github.com/xdg-go/stringprepfor stringprep of the password andgolang.org/x/crypto/pbkdf2for key derivation.[Edit: added note about dependencies]