-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear up the old SLEPc solver before we start calling SLEPc EPS. #2160
Conversation
we start calling SLEPc EPS. If we call solve() of slepc_eigen_solver multiple times, we should obtain the same answer.
With this PR:
Without this PR:
|
Well, this is definitely a huge improvement. I assume there's no performance hit from doing a wholesale clear() vs trying to figure out exactly what to zero out? That probably forces memory deallocation+reallocation but only once per solve in large chunks ought to be okay. |
We are actually doing the same thing for |
@roystgnr Anything else? |
Just wanted time for others to have a chance to weigh in. |
If we call
solve()
ofslepc_eigen_solver
multiple times, we should obtain the same answer.If we do not clear up the old EPS, it looks like there are messing things in EPS. And then we will
get a different answer when we have the second call to EPS.