Add/update special functions in RB classes. #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RBConstructionBase * RBParametrized * RBEIMConstruction In general we should not call clear() in any class destructor unless we need to manually clean up memory managed by that class. Instead, we should just let the member destructors do their thing. Refs libMesh#2710
|
The error here doesn't seem to be real... only one test failed and it has nothing to do with my change. |
jwpeterson
added a commit
to jwpeterson/libmesh
that referenced
this pull request
Sep 30, 2020
This issue was introduced by the changes in libMesh#2714 See also: discussion in libMesh#2713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general we should not call clear() in any class destructor unless
we need to manually clean up memory managed by that class. Instead, we
should just let the member destructors do their thing.
Refs #2710