-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for ShellMatrix #3606
base: devel
Are you sure you want to change the base?
Add test for ShellMatrix #3606
Conversation
I didn't think we'd turned on whitespace requirements for libMesh, even on just "spaces vs tabs"... The fact that the error message is giving MOOSE formatting rather than libMesh formatting advice isn't a good sign. You might try the contrib/bin/reindent.sh script, or if you don't have emacs on your system let me know and I can push a commit with whitespace fixes. |
9bfe917
to
1c23015
Compare
sorry for the repeated pushing; I got messed up with rebasing these few lines... |
hm; you run unit-tests with |
Make sure it doesn't fail (even if only because it's |
What is the reason that the civet-tests don't run? Is there something I can do about? |
We were having Civet issues, so perhaps the trigger never triggered? Try rewording a commit message or rebasing on master or something and then force push to see if it'll trigger a run now? |
Job Test MOOSE mac on 6f6a14f : invalidated by @jwpeterson Retry after CI issues resolved |
Job Test with threads on 6f6a14f : invalidated by @jwpeterson Retry after CI issues resolved |
Job Test debug on 6f6a14f : invalidated by @jwpeterson Retry after CI issues resolved |
Job Test clang on 6f6a14f : invalidated by @jwpeterson Retry after CI issues resolved |
Job Test 32bit on 6f6a14f : invalidated by @jwpeterson Retry after CI issues resolved |
Job Distributed make check sweep (odd) on 6f6a14f : invalidated by @jwpeterson Retry after CI issues resolved |
Job Distributed make check sweep (even) on 6f6a14f : invalidated by @jwpeterson Retry after CI issues resolved |
@BalticPinguin there seems to be a real issue with your PR which is causing the unit tests (presumably due to your new test) to time out, which subsequently causes them to be automatically cancelled. For example, in the "Test with threads" test, you can see that the unit tests are running for an hour, which is not normal:
I haven't looked into what might be causing this yet, but it seems at least possible that the issue is related to threads or to the new unit test running in parallel, so I'd suggest to start your investigation there. |
Thank you @jwpeterson for the hint: I haven't noticed the 'threads'-part. |
Following @roystgnr s comment 'we don't have test coverage', here is some.
It doesn't cover too much; but maybe it at least is a
And it would have covered the issue #3602 .