Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_prepared() more fine-grained #3759

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

roystgnr
Copy link
Member

@roystgnr roystgnr commented Jan 4, 2024

I'm still trying to figure out how to make this easy to use, but I'd like to at least test that what I've got so far still passes CI.

@lindsayad
Copy link
Member

Does "do not merge" also mean "do not review"?

@moosebuild
Copy link

Job Coverage on 7c8c1d1 wanted to post the following:

Coverage

ffa3a3 #3759 7c8c1d
Total Total +/- New
Rate 62.35% 62.36% +0.02% 98.67%
Hits 68275 68328 +53 74
Misses 41235 41236 +1 1

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@roystgnr
Copy link
Member Author

roystgnr commented Jan 4, 2024

Does "do not merge" also mean "do not review"?

It's already bad enough to need fixing, huh? ;-)

Nah, please jump in as you see fit. I've got more I'm wanting to add here, but if there's flaws in the foundation then it's probably better to fix them before I put more layers on top.

Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looking at the header this seems like a great foundation to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants