-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax some find_neighbors() assertions that can be overzealous for 1D Elems #3853
base: devel
Are you sure you want to change the base?
Relax some find_neighbors() assertions that can be overzealous for 1D Elems #3853
Conversation
Job Test MOOSE clang on efdaf92 : invalidated by @jwpeterson Unrelated failure of time_steppers/time_adaptive.test |
Ah, I think the failures I'm seeing from the unit tests are due to using a netCDF-4/HDF5 exo file... I think there is a way to convert it to something more portable to our CI, I just need to remember what that is...
|
IIRC you can use h5dump to get ASCII out of the ExodusII-HDF5 file and pipe that to ncgen to put it into an ExodusII-NetCDF3 file. |
To do the conversion, first ncdump the file to text: ncdump foo.e > foo.txt Then ncgen with the -k '64-bit offset' option: ncgen foo.txt -k '64-bit offset' -o foo.e If not already in your PATH, the ncgen utility can be found in your libMesh build directory: $LIBMESH_BUILD/contrib/netcdf/v4/ncgen/ncgen
I used |
I don't think it will be easy to make #3851 work correctly in the short term, so this PR takes a different approach which is basically to just allow incomplete/incorrect neighbor information on meshes with multiple 1D Elems meeting in a single Node. To be clear, we were already doing this so the PR doesn't make it any worse, but we did have some overzealous asserts in
find_neighbors()
which are currently being tripped when refining such meshes.