Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear incoming idx vector to local_variable_indices #3856

Merged
merged 1 commit into from
May 24, 2024
Merged

Clear incoming idx vector to local_variable_indices #3856

merged 1 commit into from
May 24, 2024

Conversation

lindsayad
Copy link
Member

This tripped me up today, and I think the average user would expect this change in behavior

@lindsayad lindsayad mentioned this pull request May 22, 2024
Merged
@moosebuild
Copy link

Job Coverage on dd44b92 wanted to post the following:

Coverage

e7bc93 #3856 dd44b9
Total Total +/- New
Rate 62.70% 62.70% +0.00% 100.00%
Hits 69239 69240 +1 1
Misses 41182 41182 - 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@lindsayad lindsayad requested review from jwpeterson and roystgnr May 24, 2024 13:35
@jwpeterson jwpeterson merged commit 69f082d into libMesh:devel May 24, 2024
21 checks passed
@lindsayad lindsayad deleted the clear-idx branch May 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwpeterson jwpeterson jwpeterson approved these changes

@roystgnr roystgnr Awaiting requested review from roystgnr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lindsayad @moosebuild @jwpeterson