Static condensation #3883
Static condensation #3883
Conversation
lindsayad
force-pushed
the
static-condensation
branch
3 times, most recently
from
bdb4d4e
to
21e8140
Compare
lindsayad
force-pushed
the
static-condensation
branch
5 times, most recently
from
aa8246a
to
1468055
Compare
Use the same mutex for both `operator<<` overloads. Refs CIVET failure https://civet.inl.gov/job/2295949/ on libMesh/libmesh#3883
lindsayad
force-pushed
the
static-condensation
branch
from
3a98105
to
11f7769
Compare
|
Job Test mac on 11f7769 : invalidated by @lindsayad |
|
Job Coverage on 31388ef wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
There was a problem hiding this comment.
There may be other issues I've missed; this is a pretty massive PR, and I'm running out of pre-vacation time, and I've already hit you with a ton of complaints. ;-)
There are a few obvious utility things we could split into smaller PRs if you wanted to get those in ASAP.
include/base/dof_map.h
Outdated
| * Fills the vector \p di with the global degree of freedom indices | ||
| * for the element. For one variable, and potentially for a | ||
| * non-default element p refinement level | ||
| */ |
There was a problem hiding this comment.
We've got to have some documentation here on how those functors work.
|
I think what I will do is split out the utilities into their own PRs. And then I'm going to add more work that's coming from using this in the HDG example. I'm pretty sure in that example I will not be allowed to remove the pressure dofs (even though they are all "internal") from the global system, so some more work will still need to be done to handle this in the library. Given that, I'm returning this to draft for now |
this will go along with @roystgnr's desire to use "condensed"/"uncondensed" verbiage over internal/trace |
|
Alright, here is one datapoint that suggests the
|
I added this at a time when I thought I would add a test with a field split of a statically condensed system, but I never did. So the need is no longer there and Roy hates it so why not remove
lindsayad
force-pushed
the
static-condensation
branch
from
0b22214
to
31388ef
Compare
|
MOOSE failure is unrelated and already codified in idaholab/moose#27555 |
|
This should be ready for another round of review |
|
I was kind of hoping I would come back and see another review on this 😢 |
include/base/dof_map.h
Outdated
| * Fills the vector \p di with the global degree of freedom indices | ||
| * for the element. For one variable, and potentially for a | ||
| * non-default element p refinement level | ||
| */ |
|
If John happens to pipe in before CI finishes then definitely address any concerns of his, but if CI finishes first then just hit "Merge" as fast as you can; I've made you suffer more than long enough. |
|
Nah, your reviews have been great. Thank you! |
|
Job Coverage, step Generate coverage on 6949cb4 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
Adds the ability to condense out element internal degrees of freedom. This can be used to eliminate internal degrees of freedom in high order CFEM or to eliminate internal degrees of freedom in HDG methods