-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow all Petsc matrix types to proceed from a common base class #3914
Conversation
And critically, always allow retrieving a PetscMatrix context from a PETSc mat. Eventually we may be able to remove the PetscMatrix from Mat constructors entirely. That would be good This change was strongly suggested by the need to convert LinearSolver to be able to handle StaticCondensation
Job Coverage on 84661f7 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
Co-authored-by: roystgnr <roy@stogners.org>
Also add a `const` to the PC pointer in `petsc_nonlinear_solver.C`
PetscMatrixBase -> PetscMatrix
5d5c8bf
to
84661f7
Compare
Job Test MOOSE clang on 84661f7 : invalidated by @lindsayad |
Job Test MOOSE GCC min on 84661f7 : invalidated by @lindsayad |
Job Test MOOSE debug on 84661f7 : invalidated by @lindsayad |
Job Test MOOSE min clang on 84661f7 : invalidated by @lindsayad |
This PR caused a build failure on the libmesh devel -> master merge for the --disable-exceptions build.
|
beautiful failed code |
Yeah, the Maybe we could add a version of these exceptionless macros that calls |
it could be good to have such a macro in the future. For now, I think we have a good change in #3925 |
With the change in libMesh#3914 to make the `_mat` data member the same as the `PetscMatrix(Base)` class, the manual destruction is now required. This refs the valgrind failures on idaholab/moose#28411
And critically, always allow retrieving a PetscMatrix context from a PETSc mat. Eventually we may be able to remove the PetscMatrix from Mat constructors entirely. That would be good
This change was strongly suggested by the need to convert LinearSolver to be able to handle StaticCondensation