Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PLAYMODE_ONCE streams respect loop points. #1309

Closed
SiegeLord opened this issue Feb 24, 2022 · 0 comments
Closed

Make PLAYMODE_ONCE streams respect loop points. #1309

SiegeLord opened this issue Feb 24, 2022 · 0 comments
Milestone

Comments

@SiegeLord
Copy link
Member

The current behavior appears to be undefined. We could define it as follows: take the loop start and end to define a slice of the stream to play, and stop playing when the stream position reaches the loop end.

Relevant code: https://github.com/liballeg/allegro5/blob/master/addons/audio/kcm_mixer.c#L217

It might be as easy as changing that piece of code to respect loop_start/end, but need to verify:

  • That we don't define this behavior already
  • How the proposed behavior interacts with seeking/stopping/resetting loop points.

Alternatively, maybe add a "sub stream" API where we create a new stream with new starts and ends.

@SiegeLord SiegeLord added this to the 5.2.8 milestone Mar 27, 2022
SiegeLord pushed a commit to SiegeLord/allegro5 that referenced this issue Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant