Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Vibrational and Electronic Data Parsing from ChemicalMixture constructor #247

Open
pbauman opened this issue Jun 25, 2018 · 2 comments

Comments

@pbauman
Copy link
Member

pbauman commented Jun 25, 2018

The only time those quantities are used is if we use StatMechThermodynamics... and we almost never use that for combustion. So we really ought to split that out and make them optional (and therefore need to add some error checking code if we try to call those methods and there's no data).

@pbauman
Copy link
Member Author

pbauman commented Jul 3, 2018

We still need the n_tr_dofs() for a lot of the thermo modeling (either IdealGasMicroThermo or StatMechThermo). But XML transport data in Cantera format has the geometry tag (can be atom, linear, or nonlinear) from which we deduce the n_tr_dofs(). So we'll want to leverage that (prefer it even?). In the ChemKin format, it looks like this is the first column after species name (0, 1, 2, respective to atom, linear, nonlinear).

@pbauman
Copy link
Member Author

pbauman commented Jul 3, 2018

Really, we ought to be able to deduce cfs (n_tr_dofs) as above and then the zns (charge) from the name (does it have a + or - or is it named e for electron). The thing left apart from molecular weight in #248 is the formation enthalpy at 0K. I wonder if we can leverage the nasa data for that?

The only place the formation enthalpy that we parse is currently used is in StatMechThermodynamics<CoeffType>::e_0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant