Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute Species data from elements #248

Open
pbauman opened this issue Jun 25, 2018 · 0 comments
Open

Compute Species data from elements #248

pbauman opened this issue Jun 25, 2018 · 0 comments

Comments

@pbauman
Copy link
Member

pbauman commented Jun 25, 2018

Somewhat related to #247...

Right now, we manually parse the molecular weight for each species from an ASCII data file... This is obviously not scalable or generalizable. Really, we should be computing molecular weight based on the element composition.

The part that's semi-related to #247 is that we also grab the formation enthalpy and few other things from this data which are only used in the StatMechThermodynamics. So we should separate out that parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant