Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in TroeFalloff / VexCL combination? #8

Closed
ddemidov opened this issue Jul 20, 2013 · 1 comment · Fixed by #9
Closed

Error in TroeFalloff / VexCL combination? #8

ddemidov opened this issue Jul 20, 2013 · 1 comment · Fixed by #9

Comments

@ddemidov
Copy link
Contributor

This line, when StateType is vex::vector<T>, should probably initialize a vector of some size with values of 0.14. Instead, it calls vex::vector(size_t) constructor, which creates a vector of size size_t(0.14) == 0.

Found this while compiling kinetics_regression_vec with clang (clang shows a warning here).
@ddemidov
Copy link
Contributor Author

Line 314, same issue.

ddemidov added a commit to ddemidov/antioch that referenced this issue Jul 20, 2013
@ddemidov
Use Antioch::constant_clone in TroeFalloff
9ce72f1 
This should fix libantioch#8
@ddemidov ddemidov mentioned this issue Jul 20, 2013
Merged
ddemidov added a commit to ddemidov/vexcl that referenced this issue Jul 20, 2013
@ddemidov
Allow to conditionally disable static context constructors
570506e 
If macro VEXCL_NO_STATIC_CONTEXT_CONSTRUCTORS is defined, then all
constructors that depend on vex::current_context() are disabled.

references libantioch/antioch#7, libantioch/antioch#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Antioch::constant_clone in TroeFalloff ddemidov/antioch
1 participant
@ddemidov