Setup Default Filenames for Install Tree #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ANTIOCH_DEFAULT_FILES_SOURCE_PATH. This is setting up for separating notion of default files in the source tree and in the install tree
typedef for DefaultFilename for backward compatibility
Don't forget '/'
pbauman
force-pushed
the
default-filename
branch
from
0412791
to
eda77f3
Compare
|
Looks good. One of these days we should add hooks for "make install prefix=something_else", though. |
|
Huh. I didn't know that was a thing. Thanks! |
pbauman
added a commit
that referenced
this pull request
Sep 7, 2015
Setup Default Filenames for Install Tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
DefaultFilenamealways pointed toward the source tree of Antioch for the default data files, with nothing able to point to the install tree. This is fine if you always have the source tree lying around, but this is a restrictive assumption. Here, we renameDefaultFilenametoDefaultSourceFilename(with a typedef forDefaultFilenamefor backward compatibility) and addDefaultInstallFilename.I'd talked about this with @roystgnr in IM a week or two ago and we'd settled on something like this PR.