Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly define android file extension as ".so" to fix jaring #68

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

Berstanio
Copy link
Contributor

This fixes android lib jaring.

The jar task determines the include paths by:

String path = ext.subProjectDir + ext.libsDir + File.separatorChar + targetFolder + File.separatorChar + target.getSharedLibFilename(ext.sharedLibName);

where target.getSharedLibFilename(ext.sharedLibName); will build up the file like:

		String suffix = os.getLibExtension().isEmpty() ? "" : "." + os.getLibExtension();

		// generate shared lib prefix and suffix, determine jni platform headers directory
		return os.getLibPrefix() + sharedLibName + architecture.toSuffix() + bitness.toSuffix() + suffix;

since suffix for android was empty, it didn't set the file extension correctly and didn't maged the ".so" files.

This should have no side effects, since the jar task is the only place that effectivly uses the value for android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants