Curved geometries: Implement length, area, point-in-polygon testing #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaston
force-pushed
the
curve-pip
branch
5 times, most recently
from
85e6830
to
f7f47c5
Compare
dbaston
changed the title
rouault
reviewed
Jun 21, 2024
rouault
reviewed
Jun 21, 2024
rouault
reviewed
Jun 21, 2024
rouault
reviewed
Jun 21, 2024
dbaston
force-pushed
the
curve-pip
branch
2 times, most recently
from
4586861
to
31a8f8a
Compare
dbaston
referenced
this pull request
Aug 15, 2024
…dicates and relate matrix calculations. * No new functions, just rework of existing functionality * "Prepared" mode now available for all predicates and relate matrix * CAPI functions GEOSPreparedRelate and GEOSPreparedRelatePattern expose new functionality * CAPI implementations of GEOSPreparedTouches, etc, that were previously defaulting into non-prepared implementations now default into the RelateNG prepared implementation * Prepared implementations for Intersects, Covers, still use the older implementations * https://lin-ear-th-inking.blogspot.com/2024/05/jts-topological-relationships-next.html * https://lin-ear-th-inking.blogspot.com/2024/05/relateng-performance.html
|
Is this targeting 3.13? |
Unless there's reason not to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends implements
getLength()andgetArea()methods for curved geometry types. It also extendsSimplePointInAreaLocatorandRayCrossingCounterto handle rings defined by a combination of line segments and circular arcs (as inCompoundCurvegeometries).The PIP functionality is not yet exposed in the Geometry API. This could either be done by adding a special case to
Geometry::intersectsor by allowingPreparedGeometryto be constructed from curved geometries. To do this,IndexedPointInAreaLocatorwould also need to support curved geometries. I'm not sure if this is actually useful for real datasets that use curved geometries, which I'd imagine to more commonly be smaller regions like tax parcels rather than the large polygons that drive the need forIndexedPointInAreaLocator.The
RayCrossingCounterwork relies on computing the intersection points between arcs and a horizontal ray so it is not as robust as the linear version, but it should be an improvement over the alternative of linearizing the arcs.