-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum C++ standard to 17 #1144
Conversation
What are the c++17 features we're dying to get our hot little hands on? |
Actually a C++14 feature:
==>
The fact that CI passes without any change shows that this is a no-brainer change |
Some things I use:
I haven't used them, but parallel STL algorithms may be useful for GEOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with this, obvs wait until 3.13 is branched before merging.
Are we ready to merge this? Just found myself reaching for an |
Yes |
As titled, this bumps our floor to C++17. It is proposed to implement this for GEOS 3.14+, not GEOS 3.13, which is expected soon.
The C++11 RFC has this comment:
I think that given we are near the end of 2024, it's time to finally increment. I don't think it requires an RFC due to us lagging the increment of many other projects and compilers on the systems that GEOS is used on. It was the C++11 increment that was disruptive and C++17 is not expected to be this late in the cycle.