Type check the tree value for Rugged::Index#read_tree #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2014 13:56
libgit2 does no type checking in `git_index_read_tree` which means that `index.read_tree` will segfault if you pass something other than a tree. This ensures that the value passed is actually a tree.
|
Also, I'm not sure if this should be handled in libgit2 as well. I was chatting with @arrbee and he indicated that rugged is a better place for this sort of type checking. |
|
libgit2, being in C, has static type checking. The function accepts a |
arthurschreiber
added a commit
that referenced
this pull request
Aug 22, 2014
Type check the tree value for Rugged::Index#read_tree
|
Looks great, thanks! |
arthurschreiber
added a commit
that referenced
this pull request
Aug 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgit2 does no type checking in
git_index_read_treewhich means thatindex.read_treewill segfault if you pass something other than a tree.This ensures that the value passed is actually a tree.