Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit: parse_commit_options returns an int #853

Merged
merged 1 commit into from
Aug 21, 2020
Merged

commit: parse_commit_options returns an int #853

merged 1 commit into from
Aug 21, 2020

Conversation

carlosmn
Copy link
Member

This looks like an oversight from some years ago when we were extracting
functionality. This function returns an int and not a VALUE like it states.

@carlosmn
commit: parse_commit_options returns an int
b7b87eb 
This looks like an oversight from some years ago when we were extracting
functionality. This function returns an `int` and not a `VALUE` like it states.
@carlosmn carlosmn merged commit d928ca6 into master Aug 21, 2020
@carlosmn carlosmn deleted the cmn/parse-commit-return branch August 21, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carlosmn