Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move driver/integrationtest to inner mod #103

Merged
merged 11 commits into from
Aug 26, 2024

Conversation

dxyinme
Copy link
Collaborator

@dxyinme dxyinme commented Aug 21, 2024

No description provided.

@dxyinme
Copy link
Collaborator Author

dxyinme commented Aug 21, 2024

我觉得可能还需要加点example, 不然变更太大了

先合入 develop,然后弄一个dev的version出来,这样就能把common的replace给省掉了

@dxyinme dxyinme mentioned this pull request Aug 21, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.89%. Comparing base (5558701) to head (7890f53).

Files Patch % Lines
dcron.go 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #103      +/-   ##
===========================================
- Coverage    88.14%   87.89%   -0.26%     
===========================================
  Files           17       15       -2     
  Lines         1097     1107      +10     
===========================================
+ Hits           967      973       +6     
- Misses          99      101       +2     
- Partials        31       33       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dxyinme dxyinme merged commit e54b943 into libi:develop Aug 26, 2024
3 checks passed
@dxyinme dxyinme deleted the dxyinme/move-driver-to-inner-mod branch August 27, 2024 12:45
dxyinme added a commit that referenced this pull request Oct 8, 2024
…109)

* add a context return value from Stop function like cron. (#100)

add a context return value from Stop function like cron

* move driver/integrationtest to inner mod (#103)

* update common package

* update

* update

* set go as 1.19

* add integration test

* let integrationtest cover dcron

* update test script

* update

* update fix

* update gocovmerge to v1.0.4

* update gomod

* update to new develop version (#104)

* fix go mod error, split commons out. (#105)

* update

* update

* move commons to dcron-contrib

* fix pipeline

* 拆分所有的drivers (#107)

* move etcd / redis driver out to dcron-contrib

* update run tests script

* update readme (#108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants