Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatible logger injection #84

Closed
wants to merge 1 commit into from
Closed

Added compatible logger injection #84

wants to merge 1 commit into from

Conversation

AH-dark
Copy link
Contributor

@AH-dark AH-dark commented Jan 6, 2024

In the production environment, we often use a globally unique logger and cooperate with ELK, etc. to collect data. It may be necessary to add an implementation of a common logger.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68982eb) 84.97% compared to head (3c2bf4e) 84.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   84.97%   84.97%           
=======================================
  Files          17       17           
  Lines        1278     1278           
=======================================
  Hits         1086     1086           
  Misses        160      160           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AH-dark AH-dark closed this by deleting the head repository Jan 7, 2024
@dxyinme
Copy link
Collaborator

dxyinme commented Jan 7, 2024

I think we don't want to involve too many dependencies into project.
we prefer to let user to implement the dlog.PrintfLogger interface and pass it to dcron when it initialized.
you can add an example subomdule to teach how to use logrus or zap to take the place of default log.

anyway, thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants