Win32 VS support #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Jan 18, 2017
Closed
This was referenced Feb 7, 2017
Closed
Closed
This was referenced Feb 24, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started commiting the modifications to make the libimobiledevice library compile on Win32 using Visual Studio
There are some grey areas, that I'm not sure, going to work, just let me know how to do these better
For example:
src/Dictionary.cpp modification, I think it's just as goog as the orignial, but I'm don't usually use std libraries
without it the compiler output is like this:
libplist\src\dictionary.cpp(155): error C2440: '' : cannot convert from 'int' to 'PList::Dictionary::iterator'
No constructor could take the source type, or constructor overload resolution was ambiguous
Another issue, is that I'm not sure, where to commit the dependent libraries, and without them the project will not compile. Right now I keep my solution file and the external libraries in a separate repository, and link libplist in it, but I'm not sure how to properly share these.