Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decrypt option to decrypt body on demand #360

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Add decrypt option to decrypt body on demand #360

merged 1 commit into from
Oct 9, 2023

Conversation

janbrummer
Copy link
Contributor

Fixes: #359

@janbrummer janbrummer changed the title Add decrypt option to decrypt body on demand Draft: Add decrypt option to decrypt body on demand Sep 20, 2023
@janbrummer
Copy link
Contributor Author

janbrummer commented Sep 20, 2023 •
edited
Loading

@Evidlo Like so?

And also a function for direct master seed access would make sense i guess. Nobody should know the internal structure...

@janbrummer
Copy link
Contributor Author

@Evidlo Like so?

And also a function for direct master seed access would make sense i guess. Nobody should know the internal structure...

I've added a master_seed property

@Evidlo
Copy link
Member

Evidlo commented Sep 20, 2023

Looks good so far. Just needs a test and a description added to the misc section of the README

@janbrummer
Copy link
Contributor Author

So i tried to implement the necessary parts in Secrets and discovered that i was wrong with master_seed... it's actually the kdf algorithm salt. Sorry about that, somehow mixed the output during debugging keepassxc. Nevertheless the PR main part is still valid. I'll adjust the property and add the necessary requested bits.

A6GibKm
A6GibKm reviewed Sep 20, 2023
View reviewed changes
pykeepass/pykeepass.py Outdated Show resolved Hide resolved
@janbrummer janbrummer force-pushed the master-seed branch 5 times, most recently from 3903672 to 5b3c1b9 Compare September 22, 2023 14:28
@janbrummer janbrummer changed the title Draft: Add decrypt option to decrypt body on demand Add decrypt option to decrypt body on demand Sep 22, 2023
@janbrummer
Copy link
Contributor Author

Secrets works fine with this solution \o/ Ready for review.

A6GibKm
A6GibKm reviewed Sep 23, 2023
View reviewed changes
Copy link
Contributor

@A6GibKm A6GibKm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this PR!

pykeepass/pykeepass.py Outdated Show resolved Hide resolved
pykeepass/pykeepass.py Show resolved Hide resolved
@Evidlo Evidlo merged commit 8fc9708 into libkeepass:master Oct 9, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A6GibKm A6GibKm A6GibKm left review comments

@Evidlo Evidlo Evidlo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide access to master seed
3 participants
@janbrummer @Evidlo @A6GibKm