Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce torpedo vendor issue in stork #1405

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rohit-PX
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
Dummy PR that shows the breaking changes in torpedo causing stork builds to fail

Does this PR change a user-facing CRD or CLI?:
no

Is a release note needed?:
no

Does this change need to be cherry-picked to a release branch?:
no

Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
@Rohit-PX Rohit-PX requested review from adityadani and pp511 May 15, 2023 23:26
@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (ed44c59) 67.76% compared to head (c4373d4) 67.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
+ Coverage   67.76%   67.82%   +0.06%     
==========================================
  Files          42       42              
  Lines        4889     4889              
==========================================
+ Hits         3313     3316       +3     
+ Misses       1242     1240       -2     
+ Partials      334      333       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants