Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test results mount from stork integration test container #1485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rohit-PX
Copy link
Contributor

@Rohit-PX Rohit-PX commented Aug 23, 2023

What type of PR is this?
integration-test

What this PR does / why we need it:

  • Stork integration tests on OCP are failing when running stork-integration test pod as the test tries to create the testresults directory but
    does not have adequate permissions
  • The solution is to run the test pod with privileged security context
  • But since we don't use the testresults directory any more (jenkins is now configured to not store that artifact) we can remove this from the stork-integration test pod spec and still make it work for OCP
  • This way we can also avoid having to run the stork-integration test pod with privileged mode

Does this PR change a user-facing CRD or CLI?:
no

Is a release note needed?:
no

Does this change need to be cherry-picked to a release branch?:
no

Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@diptiranjanpx diptiranjanpx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mount the /testresults directory in the spec so that the directory is already available and no need to create it ? it can be an alternative. If at all we are not using the result, then it looks fine to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants