-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aetos integration #1581
base: master
Are you sure you want to change the base?
Aetos integration #1581
Conversation
Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
Can one of the admins verify this patch? |
Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
@@ -134,6 +135,7 @@ func triggerMigration( | |||
projectIDMappings string, | |||
namespaceLabels map[string]string, | |||
) ([]*scheduler.Context, *scheduler.Context) { | |||
log.InfoD("Schedule mysql app") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will not always be mysql app. We should be printing the appKey instead
@@ -144,6 +146,7 @@ func triggerMigration( | |||
|
|||
err = schedulerDriver.WaitForRunning(ctxs[0], defaultWaitTimeout, defaultWaitInterval) | |||
require.NoError(t, err, "Error waiting for app to get to running state") | |||
log.InfoD("Mysql app validated") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@@ -269,6 +275,7 @@ func validateAndDestroyMigration( | |||
} | |||
|
|||
func deploymentMigrationTest(t *testing.T) { | |||
dash.TestCaseBegin("Deployment migration test", "Validating Async DR with Deployment App", "", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to pass testrailID as the third param here right?
@@ -2210,6 +2220,7 @@ func scheduleClusterPairGeneric(t *testing.T, ctxs []*scheduler.Context, | |||
err = scheduleUnidirectionalClusterPair(remotePairName, clusterPairNamespace, projectIDMappings, defaultBackupLocation, defaultSecretName, true, pairReverse) | |||
require.NoError(t, err, "failed to set unidirectional cluster pair: %v", err) | |||
} else { | |||
log.InfoD("Scheduling cluster pair using storkctl generate") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be using storkctl create and not generate. Isn't it?
} | ||
|
||
func equalPodSpreadTest(t *testing.T) { | ||
dash.TestCaseBegin("Stork scheduler equal pod spread test", "Verify equal pod spread is achieved using stork for an app", "", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same concern about first param as above. Similar concern everywhere else.
@@ -451,6 +480,7 @@ func antihyperconvergenceTestPreferRemoteOnlyTest(t *testing.T) { | |||
} | |||
|
|||
func preferRemoteNodeFalseHyperconvergenceTest(t *testing.T) { | |||
dash.TestCaseBegin("Stork scheduler prefer remote node antihyperconvergence test", "validate antihyperconvergence with preferRemoteNodeOnly flag", "", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we be passing the exact name of the test as the first param instead of a brief description?
What type of PR is this?
integration-test
What this PR does / why we need it:
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
no
Does this change need to be cherry-picked to a release branch?:
no