PWX-36917/PWX-32899_pt2: K8s DNS fix #1629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
improvement
What this PR does / why we need it:
Stork should not assume that Kubernetes DNS is configured with default
.svc.cluster.local
domainFIX:
<service>.<endpoint>
(and no.svc.cluster.local
domain)/etc/resolv.conf
to provide the correctsearch <dns-domain>
entry, so DNS resolution will still work correctlyDoes this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
no
Does this change need to be cherry-picked to a release branch?:
not sure yet
MANUAL TESTING:
This test was performed on a cluster with modified K8s DNS domain
portworx-api.portworx.svc.cluster.local
portworx-api.portworx
) is working fine:TODO: will need to fix the
openstorage
andoperator
, and vendor the fixes "in"