PWX-35885: Doing update on latest copy of volumesnapshotschedule to avoid update failures not happening on latest version. #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void update failures not happening on latest version.
|
Can one of the admins verify this patch? |
Rohit-PX
pushed a commit
to Rohit-PX/stork
that referenced
this pull request
Mar 26, 2024
…void update failures not happening on latest version. (libopenstorage#1665)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-Off-By: Diptiranjan
What type of PR is this?
improvement
What this PR does / why we need it:
Doing GetAndUpdate the volumesnapshotschedule.
Getting the latest copy and doing update is one more api call but currently it does not affect each reconciler cycle . It happens in those cycles where
Generally the policy cycles are much larger compared to reconciler cycle, hence it is ok to do one more api call when the updating is absolutely required.
Does this PR change a user-facing CRD or CLI?:
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?: