Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-35885: Doing update on latest copy of volumesnapshotschedule to avoid update failures not happening on latest version. #1665

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

diptiranjanpx
Copy link
Contributor

Signed-Off-By: Diptiranjan

What type of PR is this?
improvement

What this PR does / why we need it:
Doing GetAndUpdate the volumesnapshotschedule.
Getting the latest copy and doing update is one more api call but currently it does not affect each reconciler cycle . It happens in those cycles where

  1. New volumesnapshot need to be created
  2. Pruning of previous snapshots are required.

Generally the policy cycles are much larger compared to reconciler cycle, hence it is ok to do one more api call when the updating is absolutely required.

Does this PR change a user-facing CRD or CLI?:

Is a release note needed?:

Does this change need to be cherry-picked to a release branch?:

…void update failures not happening on latest version.
@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@pp511 pp511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diptiranjanpx diptiranjanpx merged commit 9e14fa6 into master Mar 15, 2024
3 checks passed
Rohit-PX pushed a commit to Rohit-PX/stork that referenced this pull request Mar 26, 2024
…void update failures not happening on latest version. (libopenstorage#1665)
@diptiranjanpx diptiranjanpx deleted the PWX-35885 branch May 27, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants