pwx-37596 | fix: add kubectl log command to follow log in case of failure #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pureneelesh
approved these changes
Jun 7, 2024
strivedi-px
force-pushed
the
fix-deploy-script
branch
from
9ef8b88
to
99e148b
Compare
strivedi-px
changed the title
|
@strivedi-px : can we merge this? Checks for all stork PRs are failing without this fix. |
lalat-das
pushed a commit
that referenced
this pull request
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Addresses PWX-37596. Handles the failure of
kubectl logcommand inside a retry loop and uses--sinceflag ofkubectl logcommand to reduce duplication of logs.Does this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
No
Does this change need to be cherry-picked to a release branch?:
No