PWX-37601: Using informer cache's event handling instead of native k8s watchers for pod monitoring and extender metrics. #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s watchers for pod monitoring and extender metrics.
diptiranjanpx
requested review from
adityadani,
pp511,
Rohit-PX,
gejain and
strivedi-px
pp511
approved these changes
Jun 12, 2024
pkg/cache/cache.go
Outdated
| @@ -36,6 +38,9 @@ type SharedInformerCache interface { | |||
|
|
|||
| // ListTransformedPods lists the all the Pods from the cache after applying TransformFunc | |||
| ListTransformedPods() (*corev1.PodList, error) | |||
|
|
|||
| // WatchPods watches registers the pod event handler with the informer cache | |||
There was a problem hiding this comment.
nit..watches registers?
I think need to remove watches or need to reword it
Comment on lines
+202
to
+206
| log.Warnf("Shared informer cache has not been initialized, using watch for pod monitor.") | ||
| if err := core.Instance().WatchPods("", fn, metav1.ListOptions{}); err != nil { | ||
| log.Errorf("failed to watch pods for health monitoring due to: %v", err) | ||
| return err | ||
| } |
There was a problem hiding this comment.
Wondering in what scenario will we enter inside this function? I don't think we ever will? It's still ok to keep it as is.
There was a problem hiding this comment.
Mostly not required, I also think as a failsafe , let's keep it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1795 +/- ##
==========================================
- Coverage 38.15% 38.09% -0.06%
==========================================
Files 51 51
Lines 11443 11470 +27
==========================================
+ Hits 4366 4370 +4
- Misses 6688 6707 +19
- Partials 389 393 +4 ☔ View full report in Codecov by Sentry. |
diptiranjanpx
added a commit
that referenced
this pull request
Jun 13, 2024
…s watchers for pod monitoring and extender metrics. (#1795) * PWX-37601: Using informer cache's event handling instead of native k8s watchers for pod monitoring and extender metrics. * Generated the mock files.
lalat-das
pushed a commit
that referenced
this pull request
Jun 16, 2024
…s watchers for pod monitoring and extender metrics. (#1795) * PWX-37601: Using informer cache's event handling instead of native k8s watchers for pod monitoring and extender metrics. * Generated the mock files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-Off-By: Diptiranjan
What type of PR is this?
What this PR does / why we need it:
Reducing the load by not registering for watchers with kube-api-server for pod updates.
Instead informer cache's event handling has been used.
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?: