-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWX-37811: Ignoring witness node during clusterdomain activate/deactivate with failover/failback. #1829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added couple of minor nits. Rest, looks good.
60b7610
to
7730de3
Compare
7730de3
to
351af08
Compare
351af08
to
74f2ae6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1829 +/- ##
==========================================
- Coverage 38.07% 34.45% -3.62%
==========================================
Files 51 55 +4
Lines 11477 12706 +1229
==========================================
+ Hits 4370 4378 +8
- Misses 6713 7933 +1220
- Partials 394 395 +1 ☔ View full report in Codecov by Sentry. |
…vate with failover/failback. (#1829) * PWX-37811: Ignoring witness node during clusterdomain activate/deactivate with failover/failback. * Addressed the review comments. * Added UT for getRemoteNodeName.
Signed-Off-By: Diptiranjan
What type of PR is this?
bug
What this PR does / why we need it:
Sometimes the witness clusterdomain can get deactivated instead of source clusterdomain as part of the failover workflow.
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
TBD
Does this change need to be cherry-picked to a release branch?:
yes, 24.3.0
Test: