PWX-37811: Ignoring witness node during clusterdomain activate/deactivate with failover/failback. #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strivedi-px
approved these changes
Aug 12, 2024
diptiranjanpx
force-pushed
the
PWX-37811
branch
from
60b7610
to
7730de3
Compare
strivedi-px
approved these changes
Aug 16, 2024
pp511
reviewed
Aug 16, 2024
diptiranjanpx
force-pushed
the
PWX-37811
branch
from
7730de3
to
351af08
Compare
pp511
approved these changes
Aug 19, 2024
diptiranjanpx
force-pushed
the
PWX-37811
branch
from
351af08
to
74f2ae6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1829 +/- ##
==========================================
- Coverage 38.07% 34.45% -3.62%
==========================================
Files 51 55 +4
Lines 11477 12706 +1229
==========================================
+ Hits 4370 4378 +8
- Misses 6713 7933 +1220
- Partials 394 395 +1 ☔ View full report in Codecov by Sentry. |
diptiranjanpx
added a commit
that referenced
this pull request
Aug 21, 2024
…vate with failover/failback. (#1829) * PWX-37811: Ignoring witness node during clusterdomain activate/deactivate with failover/failback. * Addressed the review comments. * Added UT for getRemoteNodeName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-Off-By: Diptiranjan
What type of PR is this?
bug
What this PR does / why we need it:
Sometimes the witness clusterdomain can get deactivated instead of source clusterdomain as part of the failover workflow.
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
TBD
Does this change need to be cherry-picked to a release branch?:
yes, 24.3.0
Test: