port-mm-code #47

jyizheng · 2015-06-27T07:41:29Z

…eelists

Nuse

merge master

thehajime · 2015-06-28T21:49:20Z

@jyizheng I can't reproduce the travis CI issue, which said the followings.

https://travis-ci.org/libos-nuse/net-next-nuse/builds/68581850#L2497

  type    = 0
failed to get interface status
ioctl: No such device
err ioctl for assign address venet0 for link -22
ioctl: No such device
err ioctl for assign netmask 255.255.255.0 for link -99
Segmentation fault
/bin/ls: cannot access /tmp/rump-server-nuse.*: No such file or directory
chmod: cannot access `/tmp/rump-server-nuse.': No such file or directory
The command "./tools/testing/libos/nuse-test.sh" exited with 1.

mine is Fedora 21 x86_64.
It only happened with optimized build (default one, OPT=yes).

could you please let me know the stack trace obtained by gdb ?
sudo gdb -c core /bin/ping then backtrace on the gdb prompt ?

jyizheng · 2015-06-28T22:47:55Z

First of all, I need to confirm whether I have set the nuse.conf file correctly.
"ifconfig" result of my machine is below.

yjiao@rowlf:/home/yjiao/net-next-nuse/arch/lib/tools$ ifconfig
eth0 Link encap:Ethernet HWaddr bc:ae:c5:6b:49:91
inet addr:130.245.153.8 Bcast:130.245.153.255 Mask:255.255.255.0
inet6 addr: fe80::beae:c5ff:fe6b:4991/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:803144 errors:0 dropped:0 overruns:0 frame:0
TX packets:357246 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:1015243408 (1.0 GB) TX bytes:26940095 (26.9 MB)

eth0:0 Link encap:Ethernet HWaddr bc:ae:c5:6b:49:91
inet addr:192.168.99.200 Bcast:192.168.99.255 Mask:255.255.255.0
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1

lo Link encap:Local Loopback
inet addr:127.0.0.1 Mask:255.0.0.0
inet6 addr: ::1/128 Scope:Host
UP LOOPBACK RUNNING MTU:65536 Metric:1
RX packets:15236 errors:0 dropped:0 overruns:0 frame:0
TX packets:15236 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:0
RX bytes:4709575 (4.7 MB) TX bytes:4709575 (4.7 MB)

"route -n":

yjiao@rowlf:/home/yjiao/net-next-nuse/arch/lib/tools$ route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric Ref Use Iface
0.0.0.0 130.245.153.1 0.0.0.0 UG 0 0 0 eth0
130.245.153.0 0.0.0.0 255.255.255.0 U 0 0 0 eth0
169.254.0.0 0.0.0.0 255.255.0.0 U 1000 0 0 eth0
192.168.99.0 0.0.0.0 255.255.255.0 U 0 0 0 eth0

My nuse.conf file looks like this:
1 interface eth0
2 address 130.245.153.8
3 netmask 255.255.255.0
4 # if macaddr is not specified, random mac addr is used.
5 viftype TAP
6
7 #interface p1p1
8 # address 172.16.0.1
9 # netmask 255.255.255.0
10 # macaddr 00:01:01:01:01:01
11 # if viftype is not specified, defualt raw socket is used.
12
13 #route
14 # network 130.245.153.0
15 # netmask 255.255.255.0
16 # gateway 130.245.153.1
17
18 route
19 network 0.0.0.0
20 netmask 0.0.0.0
21 gateway 130.245.153.1

With this configuration file, I cannot run "ping google", for which the terminal got stuck without return with message below:
tap_alloc: alloc tap interface nuse-eth0
mac address for eth0 is randomized 02:00:e0:c4:05:5c
nuse syscall proxy start at unix:///tmp/rump-server-nuse.28764
PING 130.245.153.1 (130.245.153.1) 56(84) bytes of data.

thehajime · 2015-06-29T17:48:31Z

>5 viftype TAP

This line should be viftype RAW to ping www.google.com.
viftype TAP is to join existing bridge interface.

jyizheng · 2015-06-30T05:50:25Z

Is it possible for you to log on my machine to diagnose the problem? I can
create an account for you on my machine.

On Mon, Jun 29, 2015 at 1:48 PM, Hajime Tazaki notifications@github.com
wrote:

5 viftype TAP

This line should be viftype RAW to ping www.google.com.
viftype TAP is to join existing bridge interface.

—
Reply to this email directly or view it on GitHub
#47 (comment)
.

thehajime · 2015-06-30T07:46:48Z

before creating an account for me, please check the followings:

check the stacktrace by gdb (sudo gdb /bin/ping core), and paste the stacktrace here.
- make sure you configured the limit by ulimit -c unlimited
whether the crash happens without your patch or not
your local environment (distribution, kernel, version, 32 or 64bits, etc)

jyizheng · 2015-09-01T23:11:27Z

Cannot pass the test due to things related to "rumpns_oom_lock".

thehajime · 2015-09-01T23:38:33Z

Cannot pass the test due to things related to "rumpns_oom_lock".

@jyizheng 'rumpns_' is a prefix introduced by recently. See 751adb6 commit.

it basically says the symbol 'oom_lock' is not included though it's referred by someone.
maybe adding mm/oom_kill.o into your arch/lib/Makefile would be the first step.

jyizheng · 2015-09-02T01:52:51Z

I see. page_alloc.c is using oom_lock now. I will try to fix it.

On Tue, Sep 1, 2015 at 7:38 PM, Hajime Tazaki notifications@github.com
wrote:

Cannot pass the test due to things related to "rumpns_oom_lock".

@jyizheng https://github.com/jyizheng 'rumpns_' is a prefix introduced
by recently. See 751adb6
751adb6
commit.

it basically says the symbol 'oom_lock' is not included though it's
referred by someone.
maybe adding mm/oom_kill.o into your arch/lib/Makefile would be the first
step.

—
Reply to this email directly or view it on GitHub
#47 (comment)
.

thehajime · 2015-09-06T23:43:02Z

mm/bootmem.c

@@ -48,7 +48,7 @@ static int __init bootmem_debug_setup(char *buf)
 early_param("bootmem_debug", bootmem_debug_setup);

 #define bdebug(fmt, args...) ({				\
-	if (unlikely(bootmem_debug))			\
+	if (unlikely(bootmem_debug))		\


revert unchanged white-spaces.

thehajime · 2015-09-07T00:00:46Z

@jyizheng thanks for the update.
I put comments again to your files.

I think we need a couple of rounds to clean up more.
for your particular pull request,

change PR's title in order to understand what this patch does,
close unneeded PR (simple nuse crashes with wait_queue #45,merge master #46).

I briefly memorized the general guideline for a pull request for this project.

https://github.com/libos-nuse/net-next-nuse/wiki/Pull-request-guideline

thank you for your time.

2)Use symbolic link in arch/lib/include 3)Resolve ERRORs reported by checkpatch.pl

1) resovle undefined symbol rumpns_irq_stat

thehajime · 2015-09-07T23:38:08Z

arch/lib/Makefile

@@ -127,7 +128,7 @@ quiet_cmd_objsmk = OBJS-MK   $@
 	done > $@

 $(ARCH_DIR)/objs.mk: $(ARCH_DIR)/Makefile.print $(srctree)/.config $(ARCH_DIR)/Makefile
-	+$(call if_changed,objsmk)
+	+$(call if_changed,objsmk); \


delete "; " at the end of line

(I meant revert it as it was.)

thehajime · 2015-09-07T23:48:15Z

@jyizheng I've commented on your patch.

I would remind the followings again: please update them as well.

change PR's title in order to understand what this patch does,

close unneeded PR (simple nuse crashes with wait_queue #45,merge master #46).

jyizheng · 2015-09-08T03:18:02Z

Updated my code again and renamed the pull request and deleted the old ones.

thehajime · 2015-09-08T05:05:47Z

thanks @jyizheng, I've tried to play locally with your patch.
I was wondering what is the expected behavior with this ? can we have any specifics from an execution ?
(I meant I'd like to add a test, like in tools/testing/libos/nuse-test.sh for instance to ensure this feature is working or not.)

jyizheng · 2015-09-09T14:27:24Z

I agree. I think I can write a test case that calling APIs in page_alloc.c
directly for memory allocation and then do some
arithmetic operation. Is this good enough?

On Tue, Sep 8, 2015 at 1:05 AM, Hajime Tazaki notifications@github.com
wrote:

thanks @jyizheng https://github.com/jyizheng, I've tried to play
locally with your patch.
I was wondering what is the expected behavior with this ? can we have any
specifics from an execution ?
(I meant I'd like to add a test, like in tools/testing/libos/nuse-test.sh
for instance to ensure this feature is working or not.)

—
Reply to this email directly or view it on GitHub
#47 (comment)
.

thehajime · 2015-09-09T14:44:39Z

I agree. I think I can write a test case that calling APIs in page_alloc.c
directly for memory allocation and then do some
arithmetic operation. Is this good enough?

Great !

jyizheng · 2015-09-11T06:19:06Z

Where do you want me to add the test? I don't have the scripts for testing.

Best,
Yizheng

On Wed, Sep 9, 2015 at 10:44 AM, Hajime Tazaki notifications@github.com
wrote:

I agree. I think I can write a test case that calling APIs in page_alloc.c
directly for memory allocation and then do some
arithmetic operation. Is this good enough?

Great !

—
Reply to this email directly or view it on GitHub
#47 (comment)
.

thehajime · 2015-09-11T06:44:16Z

What about creating a program in tools/testing/libos and calling from nuse-test.sh ?

yjiao and others added 13 commits June 1, 2015 12:37

Push my initial work for uploading memory manager

e929a63

add slib_env to use page_alloc.c

c50cd20

Add headers from arm/include/asm and try to initilize buddy system fr…

f0f45ab

…eelists

recover init/main.c

ed2c3fe

add WANT_PAGE_VIRTUAL to use page->virtual

dfe766d

a working version done

63b48b1

delete prink debug message

13c94a1

add a tiny change

abebc87

try to make no impact on upstream kernel

05cd7d3

solve OPT=no compiler crash

fbe7dd3

solve undefined symbol for init_mm

883afb4

Merge pull request #1 from libos-nuse/nuse

4cbbff4

Nuse

Merge pull request #2 from libos-nuse/master

07bc3b6

merge master

thehajime force-pushed the master branch from 9672e6d to 92930df Compare July 17, 2015 06:19

thehajime mentioned this pull request Aug 26, 2015

use_page_alloc #44

Closed

jyizheng added 6 commits September 1, 2015 14:25

test

6064bf2

add build.sh

305f67b

remove test

7a2bd8d

delete build.sh

56bc555

merge arch/lib/glue.c

770464d

add #endif

8f1788e

solve some unreferced symbol problem

f583c91

thehajime reviewed Sep 6, 2015
View reviewed changes

jyizheng added 4 commits September 6, 2015 20:48

resolve pull request comments

396eca8

1)Change __MR_MAX_ZONES in arch/lib/Makefile

3573715

2)Use symbolic link in arch/lib/include 3)Resolve ERRORs reported by checkpatch.pl

Lib:

34af0b6

1) resovle undefined symbol rumpns_irq_stat

disable compile time check

7b04e14

thehajime reviewed Sep 7, 2015
View reviewed changes

jyizheng changed the title ~~Master~~ port-mm-code Sep 8, 2015

resolve pull request comments

a7c9ded

add something missing in the last commit

a68bf58

Merge remote-tracking branch 'upstream/master'

fe485cf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

port-mm-code #47

port-mm-code #47

jyizheng commented Jun 27, 2015

thehajime commented Jun 28, 2015

jyizheng commented Jun 28, 2015

thehajime commented Jun 29, 2015

jyizheng commented Jun 30, 2015

thehajime commented Jun 30, 2015

jyizheng commented Sep 1, 2015

thehajime commented Sep 1, 2015

jyizheng commented Sep 2, 2015

thehajime Sep 6, 2015

thehajime commented Sep 7, 2015

thehajime Sep 7, 2015

thehajime commented Sep 7, 2015

jyizheng commented Sep 8, 2015

thehajime commented Sep 8, 2015

jyizheng commented Sep 9, 2015

thehajime commented Sep 9, 2015

jyizheng commented Sep 11, 2015

thehajime commented Sep 11, 2015

port-mm-code #47

Are you sure you want to change the base?

port-mm-code #47

Conversation

jyizheng commented Jun 27, 2015

thehajime commented Jun 28, 2015

jyizheng commented Jun 28, 2015

thehajime commented Jun 29, 2015

jyizheng commented Jun 30, 2015

thehajime commented Jun 30, 2015

jyizheng commented Sep 1, 2015

thehajime commented Sep 1, 2015

jyizheng commented Sep 2, 2015

thehajime Sep 6, 2015

Choose a reason for hiding this comment

thehajime commented Sep 7, 2015

thehajime Sep 7, 2015

Choose a reason for hiding this comment

thehajime commented Sep 7, 2015

jyizheng commented Sep 8, 2015

thehajime commented Sep 8, 2015

jyizheng commented Sep 9, 2015

thehajime commented Sep 9, 2015

jyizheng commented Sep 11, 2015

thehajime commented Sep 11, 2015