Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

add go mod #56

Closed
wants to merge 1 commit into from
Closed

add go mod #56

wants to merge 1 commit into from

Conversation

lanzafame
Copy link
Contributor

This PR will be updated once any libp2p deps that are marked as incompatible in go.mod are resolved.

Note: branch v2 contains pre-go modules master for any changes that need to be made.

This PR creates valid go modules v3. It also updates the CI to use go modules.

Once merged, master needs to be tagged v3.0.0.

@lanzafame lanzafame self-assigned this Jan 28, 2019
@ghost ghost added the status/in-progress In progress label Jan 28, 2019
Copy link
Contributor

@anacrolix anacrolix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Are you sure you want to go with the full v3 path nonsense? I'm fine with +incompatible unless you think it's definitely better or superior.

@lanzafame lanzafame force-pushed the feat/go-mod branch 4 times, most recently from f5bd52b to aa6783c Compare January 29, 2019 11:17
@lanzafame
Copy link
Contributor Author

Closing out in favour of a different approach: libp2p/go-libp2p-kad-dht#236 (comment)

@lanzafame lanzafame closed this Feb 13, 2019
@ghost ghost removed the status/in-progress In progress label Feb 13, 2019
@vyzo vyzo deleted the feat/go-mod branch August 5, 2021 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants