Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

remove the Process from the Network interface, add Close method #212

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

marten-seemann
Copy link
Contributor

No description provided.

@marten-seemann marten-seemann changed the title remove the Process from the Network interface remove the Process from the Network interface, add Close method Sep 6, 2021
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really never should have been exposed as there was no "safe" way to use it (there's always a race with shutdown, which can lead to panics). LGTM but you'll probably need to modify quite a few upstream pieces before we can merge (e.g., the DHT, I think?).

@marten-seemann
Copy link
Contributor Author

LGTM but you'll probably need to modify quite a few upstream pieces before we can merge (e.g., the DHT, I think?).

Yes, this will unfortunately be a larger change. I was thinking of not bundling it in the v0.10 release (which I'll cut after #211), so we can move these changes forward independently.

@marten-seemann marten-seemann marked this pull request as ready for review September 7, 2021 10:30
@marten-seemann
Copy link
Contributor Author

I was thinking of not bundling it in the v0.10 release (which I'll cut after #211), so we can move these changes forward independently.

I changed my mind. Using testing.Cleanup in libp2p/go-libp2p-swarm#278 made this a lot less invasive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants