This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
make Go compat post a comment on the PR #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
go-compat-comment
branch
10 times, most recently
from
eeea3b4
to
be24253
Compare
marten-seemann
force-pushed
the
go-compat-comment
branch
from
be24253
to
dd1c93f
Compare
Stebalien
approved these changes
Sep 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gocompatcurrently fails the build when an incompatible API change was made. This is annoying. It's would be a lot more helpful if it would just the author (and the reviewers) what's going on, so they can make an informed decision.Example:
Related: protocol/.github#188