This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
Replace bytes.Equal -> subtle.ConstantTimeCompare #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jul 10, 2019
crypto/ed25519.go
Outdated
| @@ -131,7 +131,7 @@ func UnmarshalEd25519PrivateKey(data []byte) (PrivKey, error) { | |||
| // Remove the redundant public key. See issue #36. | |||
| redundantPk := data[ed25519.PrivateKeySize:] | |||
| pk := data[ed25519.PrivateKeySize-ed25519.PublicKeySize : ed25519.PrivateKeySize] | |||
| if !bytes.Equal(pk, redundantPk) { | |||
| if subtle.ConstantTimeCompare(pk, redundantPk) != 1 { | |||
There was a problem hiding this comment.
This is a public key comparison so we don't need to do this.
crypto/ed25519.go
Outdated
| @@ -105,7 +105,7 @@ func (k *Ed25519PublicKey) Equals(o Key) bool { | |||
| return false | |||
| } | |||
|
|
|||
| return bytes.Equal(k.k, edk.k) | |||
| return subtle.ConstantTimeCompare(k.k, edk.k) == 1 | |||
There was a problem hiding this comment.
Also a public key comparison.
|
reverted to faster comparisons for pubkeys. going to merge once tests pass. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes reliance on short-circuiting equality comparisons which can be cryptographically unsound.