Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/streaming http #10

Merged
merged 2 commits into from
Aug 20, 2018
Merged

Feat/streaming http #10

merged 2 commits into from
Aug 20, 2018

Commits on Aug 17, 2018

  1. Support streaming HTTP requests. 

    Currently, our round-tripper assumed that requests and response's bodies
were fully read within the function. It closed the stream (connection) as
soon as it returned.

This caused streaming requests to fail, as it managed to close the
connection before the response body was fully read.

This commit closes the connection only after the response's body is read
by the user.

It also writes the request in a separate go-routine, so that it does not
have to be fully written to start reading the response.
    @hsanjuan
    hsanjuan committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    26f9957 View commit details
    Browse the repository at this point in the history

  2. gx publish 1.1.0

    @hsanjuan
    hsanjuan committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    cc104ab View commit details
    Browse the repository at this point in the history