Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] DHT query rate limiter improvements #229

Closed
wants to merge 5 commits into from
Closed

[WIP] DHT query rate limiter improvements #229

wants to merge 5 commits into from

Conversation

Stebalien
Copy link
Member

This is a start of an attempt to reduce the dials started by the DHT. However,
we need to do some real profiling with different constants and tweaks.

TODO:

  • Play with dial timeouts.
  • Play with request timeouts more.
  • Play with request/dial concurrency.
  • Try aborting dials to peers when we have better peers to try.

...

cc @raulk

Note: Read this patch by patch.

@Stebalien
reduce response timeout
e4b7d4c 
10s covers the 99.9th percentile of internet RTTs.

> Aikat, J., Kaur, J., Smith, F. D., & Jeffay, K. (2003, October). Variability
> in TCP round-trip times. In Proceedings of the 3rd ACM SIGCOMM conference on
> Internet measurement (pp. 279-284). ACM.
@Stebalien
query: enqueue peers ordered by distance
d283c6f 
We sort inside the queue itself but *only* if there's actually a backlog.
@Stebalien
query: put newly dialed peers back in the query queue
9e8e1d6 
We may now have better candidates to query.
@Stebalien
query: introduce a separate dial rate limiter.
ce55f94
@ghost ghost assigned Stebalien Jan 24, 2019
@ghost ghost added the status/in-progress In progress label Jan 24, 2019
@Stebalien Stebalien mentioned this pull request Jan 24, 2019
Closed
@Stebalien
query: release the query limit after taking the dial limit
ce9eb46 
Otherwise, we can queue up a bunch of dials in between the two limiters which
kind of ruins the querying peers in order thing.
@raulk
Copy link
Member

raulk commented Jan 30, 2019

Superseded by #237.

@raulk raulk closed this Jan 30, 2019
@ghost ghost removed the status/in-progress In progress label Jan 30, 2019
@raulk raulk deleted the fix/rate-limit-dials branch January 30, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @raulk