metrics: fix memory leak #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iulianpascalau and/or @sidenaio, could you verify that this fixes the issue? |
|
This fix resolves a leak. I don't know a business logic of code but it's been changed. After the fix, original tag map (from dht.ctx) never changes and each iteration of a loop will mutate initial state of map. So this code doesn't accumulate metrics. |
|
The metrics are being recorded in |
raulk
reviewed
Sep 4, 2019
go.mod
Outdated
| @@ -27,3 +27,5 @@ require ( | |||
| go.opencensus.io v0.21.0 | |||
| golang.org/x/xerrors v0.0.0-20190513163551-3ee3066db522 | |||
| ) | |||
|
|
|||
| go 1.13 | |||
There was a problem hiding this comment.
I've dropped this to 1.12 so it stops complaining. Although... We're going to merge some TLS changes pretty soon that'll force 1.13.
This was referenced Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #389
Credit goes to @sidenaio for finding this.