Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase the max record age to 48h (PUT_VALUE, RFM17) #794

Merged
merged 2 commits into from
Dec 11, 2022

Conversation

cortze
Copy link
Contributor

@cortze cortze commented Oct 12, 2022

Description

This PR aims to increase the default value for the IPNS records stored through the PUT_VALUE method from 36h to 48h based on RFM17 as discussed in libp2p/specs#451.

Motivation

The measurements from RFM17 were promising and have led to modifying the current republish-interval (ipfs/kubo#9326) and record's expiration time (libp2p/go-libp2p-kad-dht#793). This PR aims to homogenize the expiration of the records to 48h.

Modifications

  • Increase Config.MaxRecordAge from 36h -> 48h

@lidel lidel changed the title Increase the max record age for the PUT_VALUE method based on RFM17 feat: increase the max record age to 48h (PUT_VALUE, RFM17) Dec 8, 2022
@lidel
Copy link
Member

lidel commented Dec 11, 2022

Unifying this with value from #793 is a good idea, and raising the ceiling of expiration in itself makes things like publishing IPNS records more resilient for use cases there publisher can't be online every day under exact 24h window. 48h make a better real world default ("publish every day, no matter when, and it will be ok").

I rebased this PR to reuse variable from #793, which protects us from diverging defaults in the future.

Pinged various stakeholders but no concerns were raised here and in libp2p/specs#451
I am merging this and will release as go-libp2p-kad-dht v0.20.0

@lidel lidel merged commit c8b17c2 into libp2p:master Dec 11, 2022
@cortze
Copy link
Contributor Author

cortze commented Dec 11, 2022

Thanks @lidel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants