Protect direct and mesh peers in the connection manager #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry the connman yet I hate disabling tests, so this should be very temporary.
|
cc @raulk |
|
Implementation of protection status queries in libp2p/go-libp2p-core#158 and libp2p/go-libp2p-connmgr#76 |
|
What are the limits on mesh peers? That is, can I keep grafting to keep getting my connection protected? |
|
We only accept outbound connections for grafting when over the |
|
Note that once pruned you can't get regrafted unless the backoff elapses, which is 1minute by default. |
|
reinstated the tests, using the new connection manager interface. |
yusefnapora
approved these changes
Jun 3, 2020
Stebalien
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all the services are now starting to protect essential peers, so we should do the same.
This adds protection for direct and mesh peers.
An unfortunate side effect of this change is that we have to (temporarily I hope) disable the tests for the tags, as the connection manager doesn't offer an interface to query protected peers.edit: resolved! the tests are back.