inbound stream deduplication #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
reviewed
Jan 12, 2021
| other, dup := p.inboundStreams[peer] | ||
| if dup { | ||
| log.Debugf("duplicate inbound stream from %s; resetting other stream", peer) | ||
| other.Reset() |
There was a problem hiding this comment.
Does the muxer guarantee that an outstanding read from this stream will error out immediately as soon as we reset it? Can't remember.
There was a problem hiding this comment.
I don't really know, but it shouldn't matter much. As long as it happens promptly enough we should be fine.
comm.go
Outdated
Comment on lines
69
to
73
| p.inboundStreamsMx.Lock() | ||
| if p.inboundStreams[peer] == s { | ||
| delete(p.inboundStreams, peer) | ||
| } | ||
| p.inboundStreamsMx.Unlock() |
There was a problem hiding this comment.
Probably should put this in a defer, so that it's also run on other return paths.
There was a problem hiding this comment.
Well, there are no other relevant return code paths. The only other return is in the context cancellation case, where we don't care because we are shutting down.
Having said that, it is probably cleaner to do it in a defer so why not.
raulk
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds deduplication for inbound pubsub streams so that we always have only a single inbound stream from a peer; last one wins.