feat: msgIdGenerator

[Wondertan]

• Introduces msgIdGenerator
• Ensures msg id is generated once only
  • Besides Tracer methods rcving *RPC
• Allows setting per-topic MsgIDFunction

Closes #464

Personally, I still prefer the solution, where we compute and set Message.ID once in the pipeline and then assume it is set everywhere, instead of calling generator everywhere, but I might be missing something

[vyzo]

Thank you, this looks pretty good!

Left a couple of comments suggesting some minor improvements and then it's ready to merge.

[vyzo]

Basically the one small thing that we can and should improve on is provide a raw ID method in idGen, so that we don't have to allocate a wrapper message to compute it in the tracer.

This method could simply be refactored out of ID, and used by it.

[vyzo]

hey @Wondertan, when will you have some time to finish this? I would like to merge it soon.

It is very close, just needs to fix the allocation in the tracer by refactoring rawMsgInd.
It also needs a rebase.

[Wondertan]

Hey @vyzo, planned for tomorrow.

[Wondertan]

Rebased on master

[Wondertan]

One last thing I am concerned about is naming for options.
WithMessageIdFn is global options
WithMsgIdFunction is for topic. Would be cool to unify them somehow or just append Topic in the end.

I will also add a test for the option later today.

[vyzo]

yeah, lets call it WithTopicMessageId or something similar.

[Wondertan]

Ready.

Btw, why do you use real Swarm and not mocknet in tests? What does this give for testing?

[vyzo]

looks good, thank you!

[vyzo]

Btw, why do you use real Swarm and not mocknet in tests? What does this give for testing?

Well, we want some integration testing happening and observing effects of the actual network in use; mocknet would deny us that.